googleapis / googleapis/google-cloud-java

Update Jitter in Exponential Retry Strategy

Ouverte
#9,102 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
priority: p4 type: feature request
Langage dominant
Java
Étoiles
2.1k
Forks
1.2k
Merge moyen
1 j 23 h
PR mergées (30 j)
154

Description

**Is your feature request related to a problem? Please describe.**
In Exponential Retry Strategy, Jitter is used to prevent from several clients retrying at the same time.
However, the [existing jitter](http://googleapis.github.io/gax-java/1.8.0/apidocs/com/google/api/gax/retrying/RetrySettings.Builder.html#setJittered-boolean-) value is generated per:

```
actualDelay = rand_between(0, min(maxRetryDelay, exponentialDelay))
```

The issue with the delay is with pathological case of a short delay, e.g. 1 second.

**Describe the solution you'd like**
It would help to update jitter delay to be either one of the following:

1. `actualDelay = exponentialDelay + rand_milliseconds()`
2. `actualDelay = rand_between(exponentialDelay - E, exponentialDelay + E)` where E is constant value used to create a range with respect to exponentialDelay.

**Describe alternatives you've considered**
Turning off jitter which defeats the purpose of having jitter.

First came up in: https://github.com/googleapis/java-storage/issues/178

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.