googleapis / googleapis/google-cloud-java

[java-pubsub] TopicName.parse could throw a more detailed ValidationException

未关闭
#13,054 1 条评论 0 个 reaction 已指派 1 人 已指派给 @michaelpri10 在 GitHub 查看
api: pubsub type: feature request
主要语言
Java
星标
2.1k
派生
1.2k
平均合并
1 天 23 小时
30 天内合并 PR
157

描述

Recently I faced an issue when using the `Topic.parse(String formattedString)` method, because the String being used was an environment variable defined within a pod.
I could've been faster in resolving the issue, if the `formattedString` originating from the environment variable would be printed out as part of the ValidationException's message.

Also see my PR for this minor improvement: https://github.com/googleapis/java-pubsub/pull/1505

Current behavior:

The message `TopicName.parse: formattedString not in valid format` is shown.

```java
throw new ValidationException("TopicName.parse: formattedString not in valid format");
```

Expected / desired behavior:

The message `TopicName.parse: formattedString (${actual value of formattedString}) not in valid format` is shown.

```java
throw new ValidationException(
"TopicName.parse: formattedString (%s) not in valid format", formattedString);
```

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。