googleapis / googleapis/google-cloud-java

[java-pubsub] TopicName.parse could throw a more detailed ValidationException

Ouverte
#13,054 1 commentaire 0 réactions 1 personne assignée Assignée à @michaelpri10 Voir sur GitHub
api: pubsub type: feature request
Langage dominant
Java
Étoiles
2.1k
Forks
1.2k
Merge moyen
1 j 23 h
PR mergées (30 j)
154

Description

Recently I faced an issue when using the `Topic.parse(String formattedString)` method, because the String being used was an environment variable defined within a pod.
I could've been faster in resolving the issue, if the `formattedString` originating from the environment variable would be printed out as part of the ValidationException's message.

Also see my PR for this minor improvement: https://github.com/googleapis/java-pubsub/pull/1505

Current behavior:

The message `TopicName.parse: formattedString not in valid format` is shown.

```java
throw new ValidationException("TopicName.parse: formattedString not in valid format");
```

Expected / desired behavior:

The message `TopicName.parse: formattedString (${actual value of formattedString}) not in valid format` is shown.

```java
throw new ValidationException(
"TopicName.parse: formattedString (%s) not in valid format", formattedString);
```

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.