googleapis / googleapis/google-cloud-java

[java-pubsub] JDK 24 support and Mockito

Đang mở
#13,046 2 bình luận 0 reaction 1 người được giao Được @michaelpri10 nhận Xem trên GitHub
api: pubsub priority: p3
Ngôn ngữ chính
Java
Star
2.1k
Fork
1.2k
Merge trung bình
1 ngày 23 giờ
Pull request đã merge (30 ngày)
154

Mô tả

> Seeing a `PublisherImplTest.testShutDown:1035 » IllegalArgument Could not create type` error that seems related to this dependency update as the [referenced line](https://github.com/googleapis/java-pubsub/blob/11ccef38a5c006b3810cff03d4030bfebbff66ea/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/PublisherImplTest.java#L1035) is related to mocking the Publisher.

@michaelpri10 Easymock 5.6.0 actually has the fix for this very error (updating byte-buddy) - see https://github.com/easymock/easymock/issues/673

However this transitive byte-buddy version was not picked up because `mockito` is declared _before_ `easymock` in `google-cloud-pubsub/pom.xml`.

Flipping the order of these two dependencies did the trick.

Edit: this solution is not ideal. Let's look into upgrading mockito as well, in case it brings a later version of byte-buddy.

_Originally posted by @diegomarquezp in https://github.com/googleapis/java-pubsub/issues/2069#issuecomment-2963891932_

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.