googleapis / googleapis/google-cloud-java

Exceptions created by FlowController don't provide getMessage method implementations

Ouverte
#12,950 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
priority: p3 type: bug
Langage dominant
Java
Étoiles
2.1k
Forks
1.2k
Merge moyen
1 j 23 h
PR mergées (30 j)
154

Description

Standard Java convention for exception messages is:

- getMessage() → returns the raw detail message
- toString() → returns ClassName: getMessage()

FlowController creates exceptions without implementing getMessage() or calling super(msg) in its constructors. Consequently, getMessage() returns null.

When logging framework uses getMessage() to render the output you will get very limited text representation.
For example:

```
com.google.api.gax.batching.FlowController$MaxOutstandingRequestBytesReachedException: null
at com.google.cloud.pubsub.v1.Publisher$MessageFlowController.acquire(Publisher.java:1019)
at com.google.cloud.pubsub.v1.Publisher.publish(Publisher.java:297)
```

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.