googleapis / googleapis/google-cloud-java
Exceptions created by FlowController don't provide getMessage method implementations
- Lenguaje dominante
- Java
- Estrellas
- 2.1k
- Forks
- 1.2k
- Merge medio
- 1 d 23 h
- PR fusionados (30 d)
- 154
Descripción
Standard Java convention for exception messages is:
- getMessage() → returns the raw detail message
- toString() → returns ClassName: getMessage()
FlowController creates exceptions without implementing getMessage() or calling super(msg) in its constructors. Consequently, getMessage() returns null.
When logging framework uses getMessage() to render the output you will get very limited text representation.
For example:
```
com.google.api.gax.batching.FlowController$MaxOutstandingRequestBytesReachedException: null
at com.google.cloud.pubsub.v1.Publisher$MessageFlowController.acquire(Publisher.java:1019)
at com.google.cloud.pubsub.v1.Publisher.publish(Publisher.java:297)
```
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.