googleapis / googleapis/google-cloud-java
no clirr ignored filed generated for some proto- modules
- 主要语言
- Java
- 星标
- 2.1k
- 派生
- 1.2k
- 平均合并
- 1 天 23 小时
- 30 天内合并 PR
- 154
描述
hermetic build script [here](https://github.com/googleapis/google-cloud-java/blob/3ea90ef72b5dcdf5326db727f759b1e2d1d915f9/sdk-platform-java/hermetic_build/library_generation/owlbot/bin/write_clirr_ignore.sh#L22), only checks in proto-google-* dirs.
There are 3 proto modules that do not match the proto-google-* pattern:
google-cloud-java/java-marketingplatformadminapi/proto-admin-v1alpha
google-cloud-java/java-admanager/proto-ad-manager-v1
google-cloud-java/java-datamanager/proto-data-manager-v1
These modules are skipped by the hermetic build's write_clirr_ignore.sh script due to the hardcoded proto-google-* glob pattern.
For migration sake, changed librarian code to do the same. Separately, wonder if this was a miss in hermetic build script or intentional? @blakeli0 @diegomarquezp
We can remove the condition and generate for these after migration if this was not intentional.
Context: https://github.com/googleapis/librarian/issues/5558
贡献指南
评估
这个 Issue 还没有评估数据。