googleapis / googleapis/google-cloud-java

no clirr ignored filed generated for some proto- modules

Abierto
#12,917 1 comentario 0 reacciones 1 asignado Reclamado por @blakeli0 Ver en GitHub
priority: p3 type: feature request
Lenguaje dominante
Java
Estrellas
2.1k
Forks
1.2k
Merge medio
1 d 23 h
PR fusionados (30 d)
154

Descripción

hermetic build script [here](https://github.com/googleapis/google-cloud-java/blob/3ea90ef72b5dcdf5326db727f759b1e2d1d915f9/sdk-platform-java/hermetic_build/library_generation/owlbot/bin/write_clirr_ignore.sh#L22), only checks in proto-google-* dirs.

There are 3 proto modules that do not match the proto-google-* pattern:

google-cloud-java/java-marketingplatformadminapi/proto-admin-v1alpha
google-cloud-java/java-admanager/proto-ad-manager-v1
google-cloud-java/java-datamanager/proto-data-manager-v1
These modules are skipped by the hermetic build's write_clirr_ignore.sh script due to the hardcoded proto-google-* glob pattern.

For migration sake, changed librarian code to do the same. Separately, wonder if this was a miss in hermetic build script or intentional? @blakeli0 @diegomarquezp
We can remove the condition and generate for these after migration if this was not intentional.

Context: https://github.com/googleapis/librarian/issues/5558

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.