googleapis / googleapis/google-cloud-java

[google-auth-library-java] add validation to ensure ImpersonatedCredential can only be SA or User Credentials

Open
#12,587 0 comments 0 reactions 0 assignees View on GitHub
priority: p3 type: bug
Dominant language
Java
Stars
2.1k
Forks
1.2k
Avg merge
1d 23h
Merged PRs (30d)
157

Description

This line in javadoc specifies ImpersonatedCredential can only be SA or User Credentials in this `create()` method, but it is not enforced.

https://github.com/googleapis/google-auth-library-java/blob/a8d466f3951686ddf0f6a7ae429cab505b337c54/oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java#L120

For context: https://github.com/googleapis/google-auth-library-java/pull/1566#discussion_r1882521720

Contributor guide

Open the contributing guide

Research direction

Start in oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java at the linked javadoc and create() method, then compare the documented credential types with the current behavior. Confirm how unsupported credentials should be rejected and check the relevant authentication tests; done means the implementation enforces the documented restriction.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
authentication
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.