googleapis / googleapis/google-cloud-java
[sdk-platform-java] x-goog-api-client is incorrect when the customer uses shading
Open
priority: p3
type: feature request
- Dominant language
- Java
- Stars
- 2.1k
- Forks
- 1.2k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 154
Description
The current approach pulls the version from the jar manifest. Unfortunately this will break if the application builds an uber jar (the version will come from the uber jar rather then the generated client or gax). A more robust approach would to follow grpc's approach and embed it in a class or to use the maven-resources-plugin. I recently worked around this issue in the bigtable client:
https://github.com/googleapis/java-bigtable/pull/451
Contributor guide
Assessment
This issue has not been assessed yet.