googleapis / googleapis/google-cloud-java

[sdk-platform-java] Determine if HttpJson should allow null response back

Aperta
#12,518 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
priority: p4 type: cleanup
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

Check if this is the correct flow for GAX HttpJson:
https://github.com/googleapis/gapic-generator-java/blob/5863737238b302c6befd9670f83896be1cf190cb/gax-java/gax-httpjson/src/main/java/com/google/api/gax/httpjson/HttpJsonClientCallImpl.java#L345-L346

Currently, a null response will treated as a server error. This may be because we are REST over gRPC and gRPC requires a response in the payload.

The REST world does allow for a null response:
https://stackoverflow.com/questions/46242200/post-with-no-response-body-which-response-code-is-better-201-or-204#:~:text=or%20deleting%20%2D%20204.-,201%20Created,by%20the%20effective%20request%20URI

We should investigate and determine if this is intended/ how we want to keep it.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.