googleapis / googleapis/google-cloud-java

[sdk-platform-java] Determine if HttpJson should allow null response back

Abierto
#12,518 0 comentarios 0 reacciones 0 asignados Ver en GitHub
priority: p4 type: cleanup
Lenguaje dominante
Java
Estrellas
2.1k
Forks
1.2k
Merge medio
1 d 23 h
PR fusionados (30 d)
154

Descripción

Check if this is the correct flow for GAX HttpJson:
https://github.com/googleapis/gapic-generator-java/blob/5863737238b302c6befd9670f83896be1cf190cb/gax-java/gax-httpjson/src/main/java/com/google/api/gax/httpjson/HttpJsonClientCallImpl.java#L345-L346

Currently, a null response will treated as a server error. This may be because we are REST over gRPC and gRPC requires a response in the payload.

The REST world does allow for a null response:
https://stackoverflow.com/questions/46242200/post-with-no-response-body-which-response-code-is-better-201-or-204#:~:text=or%20deleting%20%2D%20204.-,201%20Created,by%20the%20effective%20request%20URI

We should investigate and determine if this is intended/ how we want to keep it.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.