googleapis / googleapis/google-cloud-java

[sdk-platform-java] Support `:**` for wildcard matching in routing parameters

Đang mở
#12,500 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
priority: p2 type: feature request
Ngôn ngữ chính
Java
Star
2.1k
Fork
1.2k
Merge trung bình
1 ngày 23 giờ
Pull request đã merge (30 ngày)
154

Mô tả

Storage has a need to support `:**` in the end of a routing parameter, see [proto config](https://github.com/googleapis/googleapis/blob/533398389c34b567e3ca11775fa127a111258ea1/google/storage/v2/storage.proto#L255). This was first found in [Ruby](https://b.corp.google.com/issues/277650689), but Java does not support it either after manual testing.
The original design of routing proto is not clear if this format should be supported or not. See [AIP-4222](https://google.aip.dev/client-libraries/4222) and [routing.proto](https://github.com/googleapis/googleapis/blob/533398389c34b567e3ca11775fa127a111258ea1/google/api/routing.proto) for details. There is an open [PR](https://github.com/aip-dev/google.aip.dev/pull/1067/files) to update the AIP to make it clear.
The current implementation in [PathTemplate](https://github.com/googleapis/gapic-generator-java/blob/main/api-common-java/src/main/java/com/google/api/pathtemplate/PathTemplate.java) only support `**` after `\`, we need to treat `:` as a proper delimeter as well.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.