googleapis / googleapis/google-cloud-java

[sdk-platform-java] Investigate whether manually written hashcode() methods are still needed

Đang mở
#12,455 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
priority: p3 type: feature request
Ngôn ngữ chính
Java
Star
2.1k
Fork
1.2k
Merge trung bình
1 ngày 23 giờ
Pull request đã merge (30 ngày)
154

Mô tả

There are several manually written `hashcode()` methods in the generator:

1) TypeNode: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/engine/ast/TypeNode.java#L256

2) Field: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/Field.java#L109

3) ScopeNode: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/engine/ast/ScopeNode.java#L67

4) VaporReference: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/engine/ast/VaporReference.java#L125

5) ResourceName: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/ResourceName.java#L147

6) MethodArgument: https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/MethodArgument.java#L63

7) https://github.com/googleapis/sdk-platform-java/blob/v2.34.0/gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/ResourceReference.java#L44

This is a tracking bug to investigate if they are needed or if we can remove this in favor in the built-in `hashcode()` and `equals()` methods. If they are still needed, the reasoning should be documented in the comments.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.