googleapis / googleapis/google-cloud-java

[sdk-platform-java] Update hermetic build to use same proto files in BUILD.bazel in library generation

Ouverte
#12,436 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
priority: p2 type: feature request
Langage dominant
Java
Étoiles
2.1k
Forks
1.2k
Merge moyen
1 j 23 h
PR mergées (30 j)
154

Description

https://github.com/googleapis/google-cloud-java/pull/10802 is a new library generation request for visionai.v1.
However, it failed due to prediction.proto being an empty service (e.g. no RPCs). Related issue on fixing the generator to skip generation for empty services: https://github.com/googleapis/sdk-platform-java/issues/2750

It's excluded in the visionai.v1 BUILD file: https://github.com/googleapis/googleapis/blob/master/google/cloud/visionai/v1/BUILD.bazel#L23-L36

To fix this for the long-term, we should consider either parsing BUILD.bazel to get the list of protos or consider
integrating hermetic build scripts into Bazel so that the library generation will always use the same list of protos as the BUILD.bazel file.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.