googleapis / googleapis/google-cloud-java

[sdk-platform-java] Update hermetic build to use same proto files in BUILD.bazel in library generation

Offen
#12,436 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
priority: p2 type: feature request
Vorherrschende Sprache
Java
Sterne
2.1k
Forks
1.2k
Ø Merge
1 T. 23 Std.
Gemergte PRs (30 T.)
154

Beschreibung

https://github.com/googleapis/google-cloud-java/pull/10802 is a new library generation request for visionai.v1.
However, it failed due to prediction.proto being an empty service (e.g. no RPCs). Related issue on fixing the generator to skip generation for empty services: https://github.com/googleapis/sdk-platform-java/issues/2750

It's excluded in the visionai.v1 BUILD file: https://github.com/googleapis/googleapis/blob/master/google/cloud/visionai/v1/BUILD.bazel#L23-L36

To fix this for the long-term, we should consider either parsing BUILD.bazel to get the list of protos or consider
integrating hermetic build scripts into Bazel so that the library generation will always use the same list of protos as the BUILD.bazel file.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.