googleapis / googleapis/google-cloud-java

[sdk-platform-java] Future Improvements for "X.509 WIF mTLS-transport support in Java Gax lib"

Aperta
#12,377 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
priority: p3 type: feature request
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

This is a follow-up for https://github.com/googleapis/sdk-platform-java/issues/3851 to address some secondary code organization concerns discovered during PR review. Details are in the linked PR comments, but to summarize a few key points:

1. EndpointContext, GrpcChannelProvider, and HttpJsonChannelProvider each instantiate its own mTLS provider today using a similar but duplicated flow - this could potentially be refactored so that a single mTLS provider can be shared between EndpointContext and the Channel providers.

2. A related concern is to address is the nullability of "CertificateBasedAccess" helper in EndpointContext to make it non-Nullable without breaking existing tests.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.