googleapis / googleapis/google-cloud-java

[sdk-platform-java] Future Improvements for "X.509 WIF mTLS-transport support in Java Gax lib"

Offen
#12,377 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
priority: p3 type: feature request
Vorherrschende Sprache
Java
Sterne
2.1k
Forks
1.2k
Ø Merge
1 T. 23 Std.
Gemergte PRs (30 T.)
154

Beschreibung

This is a follow-up for https://github.com/googleapis/sdk-platform-java/issues/3851 to address some secondary code organization concerns discovered during PR review. Details are in the linked PR comments, but to summarize a few key points:

1. EndpointContext, GrpcChannelProvider, and HttpJsonChannelProvider each instantiate its own mTLS provider today using a similar but duplicated flow - this could potentially be refactored so that a single mTLS provider can be shared between EndpointContext and the Channel providers.

2. A related concern is to address is the nullability of "CertificateBasedAccess" helper in EndpointContext to make it non-Nullable without breaking existing tests.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.