googleapis / googleapis/google-cloud-java

[java-bigquery] Don't throw exception in BigQueryResultSet.close()

未关闭
#12,164 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
api: bigquery priority: p2 type: feature request
主要语言
Java
星标
2.1k
派生
1.2k
平均合并
1 天 23 小时
30 天内合并 PR
154

描述

**Is your feature request related to a problem? Please describe.**
`Connection.execute*()` nethods return BigQueryResult, which contains BigQueryResultSet the inheritor of ResultSet.
Most of the methods of BigQueryResultSet are not implemented including `close()`.
Unfortunately, IntelliJ Idea strongly suggests wrapping `ResultSet` into `try-with-resources` block, which we can't do because it will trow an exception.

**Describe the solution you'd like**
Don't throw 'Not implemented' exception in the close method.

**Describe alternatives you've considered**
Fully implement `close` method to free underlying resources.

**Additional context**
IntelliJ Idea's waring:
![image](https://github.com/googleapis/google-cloud-java/assets/4300612/c946c9bb-044d-40cd-9019-d16dd3a29d5a)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。