googleapis / googleapis/google-cloud-java

[java-bigquery] Don't throw exception in BigQueryResultSet.close()

Aperta
#12,164 0 commenti 1 reazione 0 assegnatari Vedi su GitHub
api: bigquery priority: p2 type: feature request
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

**Is your feature request related to a problem? Please describe.**
`Connection.execute*()` nethods return BigQueryResult, which contains BigQueryResultSet the inheritor of ResultSet.
Most of the methods of BigQueryResultSet are not implemented including `close()`.
Unfortunately, IntelliJ Idea strongly suggests wrapping `ResultSet` into `try-with-resources` block, which we can't do because it will trow an exception.

**Describe the solution you'd like**
Don't throw 'Not implemented' exception in the close method.

**Describe alternatives you've considered**
Fully implement `close` method to free underlying resources.

**Additional context**
IntelliJ Idea's waring:
![image](https://github.com/googleapis/google-cloud-java/assets/4300612/c946c9bb-044d-40cd-9019-d16dd3a29d5a)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.