googleapis / googleapis/google-cloud-java

[java-bigquery] Don't throw exception in BigQueryResultSet.close()

Open
#12,164 0 comments 1 reaction 0 assignees View on GitHub
api: bigquery priority: p2 type: feature request
Dominant language
Java
Stars
2.1k
Forks
1.2k
Avg merge
1d 23h
Merged PRs (30d)
154

Description

**Is your feature request related to a problem? Please describe.**
`Connection.execute*()` nethods return BigQueryResult, which contains BigQueryResultSet the inheritor of ResultSet.
Most of the methods of BigQueryResultSet are not implemented including `close()`.
Unfortunately, IntelliJ Idea strongly suggests wrapping `ResultSet` into `try-with-resources` block, which we can't do because it will trow an exception.

**Describe the solution you'd like**
Don't throw 'Not implemented' exception in the close method.

**Describe alternatives you've considered**
Fully implement `close` method to free underlying resources.

**Additional context**
IntelliJ Idea's waring:
![image](https://github.com/googleapis/google-cloud-java/assets/4300612/c946c9bb-044d-40cd-9019-d16dd3a29d5a)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.