googleapis / googleapis/google-cloud-cpp
Use first client with a `List*()` operation for quickstart skeleton
Offen
cpp: generator
cpp: operator
type: cleanup
- Vorherrschende Sprache
- C++
- Sterne
- 659
- Forks
- 462
- Ø Merge
- 1 T. 2 Std.
- Gemergte PRs (30 T.)
- 89
Beschreibung
The scaffold generator runs without any context of the protos in use. We could move the generation of the quickstart skeleton to have access to the service definition. With that information we could generate a correct include file here:
https://github.com/googleapis/google-cloud-cpp/blob/43cd3d9a65df32310bca8d8878ee322d73493a03/generator/internal/scaffold_generator.cc#L938
and maybe pick the first `List*()` overload consuming a string (with some fallback to "EDIT HERE" if there is none):
https://github.com/googleapis/google-cloud-cpp/blob/43cd3d9a65df32310bca8d8878ee322d73493a03/generator/internal/scaffold_generator.cc#L953
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.