googleapis / googleapis/google-cloud-cpp
Use first client with a `List*()` operation for quickstart skeleton
Open
cpp: generator
cpp: operator
type: cleanup
- Dominant language
- C++
- Stars
- 659
- Forks
- 462
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 89
Description
The scaffold generator runs without any context of the protos in use. We could move the generation of the quickstart skeleton to have access to the service definition. With that information we could generate a correct include file here:
https://github.com/googleapis/google-cloud-cpp/blob/43cd3d9a65df32310bca8d8878ee322d73493a03/generator/internal/scaffold_generator.cc#L938
and maybe pick the first `List*()` overload consuming a string (with some fallback to "EDIT HERE" if there is none):
https://github.com/googleapis/google-cloud-cpp/blob/43cd3d9a65df32310bca8d8878ee322d73493a03/generator/internal/scaffold_generator.cc#L953
Contributor guide
Assessment
This issue has not been assessed yet.