googleapis / googleapis/google-api-python-client

Support google.api_core.retry in googleapiclient.discovery.build?

未关闭
#2,688 0 条评论 1 个 reaction 已指派 1 人 已被 @gkevinzheng 认领 在 GitHub 查看
主要语言
Python
星标
8.9k
派生
2.6k
平均合并
2 天 28 分钟
30 天内合并 PR
17

描述

It looks like `googleapiclient.discovery.build()` is super limited wrt to retry support is that correct?

In general is `googleapiclient.discovery.build` for legacy clients or APIs that Google doesn't support as fully? Some APIs use it and others have a specific library I can import and use `google.api_core.retry` with.

`Retry` has exponential backoff built into it, a bunch of sane defaults, and other features.

I generally just set a timeout value and let it use the default backoff settings which is so simple and effective for 99% of use cases I find.

Could the service client just support a Retry like this?

```
from googleapiclient.discovery import (build)
from google.api_core.retry import Retry

my_retry = Retry(timeout=30)
service = build("admin", "directory_v1", retry=my_retry)
```

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。