googleapis / googleapis/google-api-python-client

Support google.api_core.retry in googleapiclient.discovery.build?

Aperta
#2,688 0 commenti 1 reazione 1 assegnatario Rivendicata da @gkevinzheng Vedi su GitHub
Lingua principale
Python
Stelle
8.9k
Fork
2.6k
Merge medio
2g 28m
PR unite (30g)
17

Descrizione

It looks like `googleapiclient.discovery.build()` is super limited wrt to retry support is that correct?

In general is `googleapiclient.discovery.build` for legacy clients or APIs that Google doesn't support as fully? Some APIs use it and others have a specific library I can import and use `google.api_core.retry` with.

`Retry` has exponential backoff built into it, a bunch of sane defaults, and other features.

I generally just set a timeout value and let it use the default backoff settings which is so simple and effective for 99% of use cases I find.

Could the service client just support a Retry like this?

```
from googleapiclient.discovery import (build)
from google.api_core.retry import Retry

my_retry = Retry(timeout=30)
service = build("admin", "directory_v1", retry=my_retry)
```

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.