google / google/transit

Allow defining new `Shape` for trips with `TripUpdate.TripDescriptor.schedule_relationship=REPLACEMENT`

オープン
#653 コメント 5 件 リアクション 0 件 担当者 0 名 GitHub で見る
GTFS Realtime
主要言語
言語のデータがありません
スター
1.1k
フォーク
225
平均マージ
7日 17時間
マージ済み PR(30日)
3

説明

### Describe the problem

When using `TripUpdate.TripDescriptor.schedule_relationship=REPLACEMENT`, a new stop sequence must be given in `TripUpdate.stop_time_update`. However, the current wording of `TripUpdate.TripProperties.shape_id` states:

https://github.com/google/transit/blob/474750a163088673df718838d4a1bb093391f9af/gtfs-realtime/spec/en/reference.md?plain=1#L267

> The order of stops (stop sequences) for this trip must remain the same as (CSV) GTFS.

Would it make sense to have the possibility of defining a new shape for trips with changed stop sequences?

### Use cases

A trip has its stop sequence replaced and now the old shape does not fit the new stops. Updating the shape would improve the end user experience.

### Proposed solution

Change the wording from

> The order of stops (stop sequences) for this trip must remain the same as (CSV) GTFS.

to this

> The order of stops (stop sequences) for this trip must remain the same as (CSV) GTFS, unless `schedule_relationship` is `REPLACEMENT`, in which case `shape_id` may instead describe the vehicle path for the new stop sequence declared in `TripUpdate.stop_time_update`.

### Additional information

I could not find a previous issue related to this. Also, should the wording include other types of trips, for example, `TripUpdate.TripDescriptor.schedule_relationship=NEW`?

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start with the linked GTFS Realtime reference.md passage for TripUpdate.TripProperties.shape_id and review the surrounding schedule_relationship and stop_time_update definitions. Check the existing comments for scope, including whether NEW trips are included. Done means reaching agreement on the semantics and updating the specification wording consistently.

索引モデルが issue の本文から書いたものです。

評価

領域
documentation
issue の種類
ドキュメント
難易度
3/5
見積もり時間
1〜2日
活発さ
活発
明瞭さ
おおむね明確
初心者へのやさしさ
55/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。