google / google/s2-geometry-library-java

Request for Guidance - Point in Polygon and S2

オープン
#5 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Java
スター
587
フォーク
231
PR マージ指標
30日以内にマージされた PR はありません

説明

Would it be possible for the good folks here to please help me with a problem that I am trying to solve with the S2 geometry library? I am a complete novice, so please bear with me if I do not make sense.

**Problem**
I am trying to determine the best way to write an offline point-in-polygon check for the Android platform. Essentially, convert (lat,lng) to a country. In future, I plan to increase the granularity to regions, states, provinces, counties and cities/towns.

**Research**
My initial research landed me up on https://github.com/AReallyGoodName/OfflineReverseGeocode with http://download.geonames.org/export/dump/cities1000.zip. From what I understand, this is (lat,lng) to nearest neighbor. Now, I do get the country from this, but it relies on finding the nearest neighbor city with population, which may not be accurate.

Further research led me to S2. It is here that I am struggling, and request your guidance.

**Current Approach**
A) Computation at app startup:
1) Get geojson co-ordinates from http://download.geonames.org/export/dump/shapes_simplified_low.zip.
2) For each country,
i) Convert geojson co-ordinates into S2 LatLng and then S2 Loops.
ii) Build S2 Polygon using S2 Loops.
iii) If MultiPolygon, use S2PolygonBuilder.addPolygon() to add additional polygons.

B) LatLng input during app functioning:
1) Convert Lat Lng Input to S2Point.
2) Iterate over country polygons, checking for S2Polygon.contains(S2Point).
3) Return country.

**Questions**
1) Some geojson countries are "multipolygon", whereas there is no multipolygon in S2. Are S2 polygons equivalent to multipolygons from geojson?
2) Can the geojson to S2Polygon initial computation result be persisted, to avoid re-computation at app startup?
3) Geonames geojson input does not seem to conform to counter clockwise (CCW) convention. Would S2PolygonBuilder be able to tackle this correctly?
4) Is there a better way to search for point-in-polygon rather than iterating over each countries S2Polygons.contains function call? Does this mechanism also help avoid polygon re-computation?
5) Is there a better way to achieve the offline point-in-polygon check?
6) Is there a better (small, accurate) source for country boundaries for use with S2?

Thank you for your time.

@eengle @hagbard @kluever @cpovirk

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

リポジトリのファイル、テスト、エントリポイントは指定されていません。まず、参照されている S2Polygon、S2PolygonBuilder、S2Loop、S2Point の API を確認し、その後、Android とオフラインの point-in-polygon に関する6つの質問のうち、どれをリポジトリへの具体的な変更にすべきかを明確にしてください。スコープと受け入れ基準について合意できれば完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
android, java
領域
computer-graphics, mobile-dev
issue の種類
機能追加
難易度
5/5
見積もり時間
1週間以上
活発さ
停滞
明瞭さ
説明が足りない
初心者へのやさしさ
15/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。