google / google/python-fire

**kwargs unexpectedly parses flags for later chained method

未關閉
#659 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Python
星號
28.2k
分支
1.5k
PR 合併指標
30 天內沒有已合併 PR

描述

Suppose we have the following program

```python
from dataclasses import dataclass

@dataclass
class MyClass:
x: int

def transform(self, **kwargs):
return MyClass(self.x * kwargs.get("multiplier", 2))

def do_something(self, msg):
print(f"{msg}: {self.x}")

my_obj = MyClass(3)
```

And we call it with `python -m fire my_module my_obj transform --multiplier=3 do_something --msg="test"`, then the `--msg` is parsed when calling `transform` into the `kwargs` dict. Then it errors saying `--msg` is missing. Can we instead support parsing flags before the next chained method call? The kwargs is useful for example, to transform the object in ways that only implementation classes know what to do.

My current workarounds are (1) pass msg as positional arg to `do_something`, (2) have `do_something` take `**kwargs` and call `transform` within it. Neither is ideal as (1) would surprise anyone who uses my code and (2) adds extra plumbing that could be avoided.

貢獻指南

開啟貢獻指南

研究方向

使用所示的 `python -m fire` 命令以及鏈式呼叫 `transform` 和 `do_something` 重現此行為。首先追蹤鏈式方法呼叫的引數解析;完成的標準是,`transform` 之後的 flags 會傳遞給 `do_something`,而不是被吸收到 `transform` 的 `kwargs` 中,並為此範例提供 coverage。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
cli
Issue 類型
功能
難度
4/5
預估耗時
3-5 天
活躍度
冷清
描述清晰度
基本清楚
新手友好度
55/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。