google / google/python-fire

**kwargs unexpectedly parses flags for later chained method

Abierto
#659 1 comentario 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
28.2k
Forks
1.5k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Suppose we have the following program

```python
from dataclasses import dataclass

@dataclass
class MyClass:
x: int

def transform(self, **kwargs):
return MyClass(self.x * kwargs.get("multiplier", 2))

def do_something(self, msg):
print(f"{msg}: {self.x}")

my_obj = MyClass(3)
```

And we call it with `python -m fire my_module my_obj transform --multiplier=3 do_something --msg="test"`, then the `--msg` is parsed when calling `transform` into the `kwargs` dict. Then it errors saying `--msg` is missing. Can we instead support parsing flags before the next chained method call? The kwargs is useful for example, to transform the object in ways that only implementation classes know what to do.

My current workarounds are (1) pass msg as positional arg to `do_something`, (2) have `do_something` take `**kwargs` and call `transform` within it. Neither is ideal as (1) would surprise anyone who uses my code and (2) adds extra plumbing that could be avoided.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.