google / google/google-java-format

Support JEP 512: Compact Source Files and Instance Main Methods

Đang mở
#1,216 3 bình luận 3 reaction 0 người được giao Xem trên GitHub
Java 25
Ngôn ngữ chính
Java
Star
6.2k
Fork
937
Merge trung bình
6 phút
Pull request đã merge (30 ngày)
3

Mô tả

In https://github.com/enola-dev/enola/pull/974 for https://github.com/enola-dev/enola/issues/971 with https://github.com/enola-dev/enola/issues/970, I am using "Java's fancy modern main style", AKA the JEP 445 & 463 & 477 & 495 stuff:

* https://openjdk.org/jeps/445
* https://openjdk.org/jeps/463
* https://openjdk.org/jeps/477
* https://openjdk.org/jeps/495

So I have e.g. a `hello.java` which looks e.g. like this, which is actually valid (with `--enable-preview`) Java 21 syntax:

```java
import static java.lang.System.out;

void main() {
out.println("Hello World: " + dev.enola.common.Version.get());
}
```

`google-java-format` chokes on this with:

stderr: learn/jbang/hello.java:26:6: error: did not generate token "void"
void main() {

This is on v1.25.1, which is the 2nd most recent release today; looking at [the 1.25.2 Release Notes](https://github.com/google/google-java-format/releases), I have no reason to believe that this (just) got fixed there; ergo reporting this here.

Stating that `google-java-format` does not support `--enable-preview` would be valid. But from what little I figured (so far) this feature, contrary to e.g. those preview String Templates which then got removed again, this syntax appears to be here to stay, so probably should be supported, sooner or later.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.