google / google/cppdap

ignores terminated event when body is empty (DAP protocol violation)

未关闭
#152 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
C++
星标
192
派生
66
PR 合并指标
30 天内没有已合并 PR

描述

When cppdap receives a terminated event with an empty body (e.g., {"type":"event","event":"terminated","body":{}}), it ​​silently skips processing​​ the event.

When debugging Python applications using `cppdap`, the debug adapter correctly sends a terminated event when the application finishes, but with an empty body field. Currently, cppdap silently ignores these events, preventing my application from handling the proper debug session termination.

this is debugpy`s log:

```
D+00000.049: Server[1] --> {
"pydevd_cmd_id": 129,
"seq": 62,
"type": "event",
"event": "terminated",
"body": {}
}

D+00000.050: /handling #62 event "terminated" from Server[1]/
Closing Server[1] message stream

D+00000.050: Exiting message loop for channel Server[1]: No more messages

I+00000.051: /handling disconnect from Server[1]/
Server[1] has disconnected; finalizing Session[1].

I+00000.051: All debug servers disconnected; waiting for remaining sessions...

D+00000.051: /handling disconnect from Server[1]/
Client[1] <-- {
"seq": 30,
"type": "event",
"event": "terminated"
}
```

According to the DAP protocol specification, the body field in terminated events is optional and may be empty. cppdap should properly process these events regardless of the body content.

Additionally, I believe that in commit https://github.com/google/cppdap/commit/574190fb634d803c8abc66838e5b8d639d6e2ee2, while modifications were made to address similar issues, it still fails to properly handle events with empty bodies as intended.

related issue: https://github.com/google/cppdap/issues/81

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。