google / google/cppdap

ignores terminated event when body is empty (DAP protocol violation)

Abierto
#152 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
C++
Estrellas
192
Forks
66
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

When cppdap receives a terminated event with an empty body (e.g., {"type":"event","event":"terminated","body":{}}), it ​​silently skips processing​​ the event.

When debugging Python applications using `cppdap`, the debug adapter correctly sends a terminated event when the application finishes, but with an empty body field. Currently, cppdap silently ignores these events, preventing my application from handling the proper debug session termination.

this is debugpy`s log:

```
D+00000.049: Server[1] --> {
"pydevd_cmd_id": 129,
"seq": 62,
"type": "event",
"event": "terminated",
"body": {}
}

D+00000.050: /handling #62 event "terminated" from Server[1]/
Closing Server[1] message stream

D+00000.050: Exiting message loop for channel Server[1]: No more messages

I+00000.051: /handling disconnect from Server[1]/
Server[1] has disconnected; finalizing Session[1].

I+00000.051: All debug servers disconnected; waiting for remaining sessions...

D+00000.051: /handling disconnect from Server[1]/
Client[1] <-- {
"seq": 30,
"type": "event",
"event": "terminated"
}
```

According to the DAP protocol specification, the body field in terminated events is optional and may be empty. cppdap should properly process these events regardless of the body content.

Additionally, I believe that in commit https://github.com/google/cppdap/commit/574190fb634d803c8abc66838e5b8d639d6e2ee2, while modifications were made to address similar issues, it still fails to properly handle events with empty bodies as intended.

related issue: https://github.com/google/cppdap/issues/81

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.