google / google/adk-python

adk web: Links in chat responses should open in a new tab

Đang mở
#4,580 10 bình luận 0 reaction 1 người được giao Được giao cho @wyf7107 Xem trên GitHub
needs review web
Ngôn ngữ chính
Python
Star
21.5k
Fork
4k
Merge trung bình
1 ngày 14 giờ
Pull request đã merge (30 ngày)
37

Mô tả

### Description

When the agent responds with a URL in `adk web`, clicking it navigates away
from the chat — the user loses their conversation. Links rendered in chat
messages should open in a new browser tab.

### Steps to reproduce

1. `adk web --reload_agents`
2. Ask the agent a question that produces a response containing a URL
3. Click the link in the rendered chat message
4. The browser navigates away from the ADK web UI — the conversation is lost

### Expected behavior

External links (`http://…` / `https://…`) in chat responses should open in a
new tab (`target="_blank"`) with `rel="noopener noreferrer"`.

### Suggested fix

In the Angular web UI component that renders chat messages, add
`target="_blank"` and `rel="noopener noreferrer"` to auto-linked URLs.

For example, if links are rendered via Angular's markdown/HTML binding, a
directive or pipe could post-process `` elements:

```ts
// Wherever chat message HTML is rendered:
// Add target="_blank" rel="noopener noreferrer" to external
tags

Workaround

We're currently injecting a MutationObserver script into
google/adk/cli/browser/index.html post-install that patches links as they
appear in the DOM. This works but has to be re-applied after every
pip install.

Environment

- adk-python version: latest (pip)
- Browser: Chrome / Safari / Firefox (all affected)
- OS: macOS / Linux

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.