google / google/adk-python

Loosing SSE session from the browser shouldn't break the agent run

Đang mở
#4,029 8 bình luận 1 reaction 1 người được giao Được giao cho @wyf7107 Xem trên GitHub
needs review web
Ngôn ngữ chính
Python
Star
21.5k
Fork
4k
Merge trung bình
1 ngày 22 giờ
Pull request đã merge (30 ngày)
31

Mô tả

**Describe the bug**
Prerequisites:

Web chat UI started with `adk web` for a simple agent with only a function tool that hangs for 2 minutes.

Reproduction:

1. Submit a request to wait for 2 minutes and wait for tool to start executing
2. Refresh browser window or terminate `/run_sse` SSE exchnage opened by the browser in any other way
3. Find the tool call in a scrambled state. The trace will mark the completion at the time of SSE session termination; the tool will never complete, and the agent will never return a response. The session is in a strange state.

Expected behavior:

Browser window refresh shouldn't affect the session in any way.

**To Reproduce**

Start a long-running tool, then refresh the browser window mid-execution: the execution response will never be processed, and no further processing will happen in this Session until a new message is sent.

**Expected behavior**
Disconnection of the browser SSE session shouldn't break the running execution of the agent / tools.

**Screenshots**

Before refresh:
Image
After refresh:
Image

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.