google / google/GoogleSignIn-iOS
Revoke request uses GET instead of POST
- Lenguaje dominante
- Objective-C
- Estrellas
- 750
- Forks
- 282
- Merge medio
- 2 d 15 h
- PR fusionados (30 d)
- 9
Descripción
-disconnectWithCompletion: sends the revocation request over GET, because startFetchURL: builds an NSMutableURLRequest without setting HTTPMethod.
Our documentation ([mobile](https://developers.google.com/identity/protocols/oauth2/native-app#tokenrevoke)) says to use a POST request; and [RFC 7009 section 2.1](https://datatracker.ietf.org/doc/html/rfc7009#section-2.1) specifies a POST carrying the token in a form-encoded body.
Guía de contribución
Línea de trabajo
Start at -disconnectWithCompletion: and follow its call to startFetchURL:, where the NSMutableURLRequest is created. Compare the revocation request with the linked Google documentation and RFC 7009 section 2.1; done means the request uses POST and carries the token in a form-encoded body.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- objective-c
- Área
- authentication
- Tipo de issue
- Error
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Tranquilo
- Claridad
- Bien especificado
- Aptitud para principiantes
- 72/100