google / google/GoogleSignIn-iOS
Revoke request uses GET instead of POST
- Vorherrschende Sprache
- Objective-C
- Sterne
- 750
- Forks
- 282
- Ø Merge
- 2 T. 15 Std.
- Gemergte PRs (30 T.)
- 9
Beschreibung
-disconnectWithCompletion: sends the revocation request over GET, because startFetchURL: builds an NSMutableURLRequest without setting HTTPMethod.
Our documentation ([mobile](https://developers.google.com/identity/protocols/oauth2/native-app#tokenrevoke)) says to use a POST request; and [RFC 7009 section 2.1](https://datatracker.ietf.org/doc/html/rfc7009#section-2.1) specifies a POST carrying the token in a form-encoded body.
Beitragsleitfaden
Rechercherichtung
Start at -disconnectWithCompletion: and follow its call to startFetchURL:, where the NSMutableURLRequest is created. Compare the revocation request with the linked Google documentation and RFC 7009 section 2.1; done means the request uses POST and carries the token in a form-encoded body.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- objective-c
- Bereich
- authentication
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Ruhig
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 72/100