google / google/GoogleSignIn-iOS
Add test coverage for the userinfo profile-fetch fallback
- Lingua principale
- Objective-C
- Stelle
- 750
- Fork
- 282
- Merge medio
- 2g 15h
- PR unite (30g)
- 9
Descrizione
The userinfo request in GIDSignIn.m does not have any test coverage (this is the fallback that fetches basic profile data if the ID token doesn't carry it).
Suggested changes:
- Set up a sign in whose ID token lacks profile claims, so the profile-fetch fallback runs
- Assert the userinfo request URL: scheme, host, path /oauth2/v3/userinfo, and the access_token query parameter
- Include a token containing URL-reserved characters (&, =, #). (testDisconnectNoCallback_tokenWithReservedCharacters does this to test recent changes that ensure those characters are encoded correctly)
- Assert the returned data maps correctly onto GIDProfileData
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Start with GIDSignIn.m and the existing testDisconnectNoCallback_tokenWithReservedCharacters test for setup and URL-encoding behavior. Add coverage for an ID token without profile claims, verify the /oauth2/v3/userinfo URL and encoded access_token, and confirm the response maps correctly onto GIDProfileData.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- objective-c
- Ambito
- authentication, mobile, testing
- Tipo di issue
- Funzionalità
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Stato di attività
- Tranquilla
- Chiarezza
- Specificata chiaramente
- Idoneità per principianti
- 76/100