google / google/GoogleSignIn-iOS
Add test coverage for the userinfo profile-fetch fallback
- Lenguaje dominante
- Objective-C
- Estrellas
- 750
- Forks
- 282
- Merge medio
- 2 d 15 h
- PR fusionados (30 d)
- 9
Descripción
The userinfo request in GIDSignIn.m does not have any test coverage (this is the fallback that fetches basic profile data if the ID token doesn't carry it).
Suggested changes:
- Set up a sign in whose ID token lacks profile claims, so the profile-fetch fallback runs
- Assert the userinfo request URL: scheme, host, path /oauth2/v3/userinfo, and the access_token query parameter
- Include a token containing URL-reserved characters (&, =, #). (testDisconnectNoCallback_tokenWithReservedCharacters does this to test recent changes that ensure those characters are encoded correctly)
- Assert the returned data maps correctly onto GIDProfileData
Guía de contribución
Línea de trabajo
Start with GIDSignIn.m and the existing testDisconnectNoCallback_tokenWithReservedCharacters test for setup and URL-encoding behavior. Add coverage for an ID token without profile claims, verify the /oauth2/v3/userinfo URL and encoded access_token, and confirm the response maps correctly onto GIDProfileData.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- objective-c
- Área
- authentication, mobile, testing
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Tranquilo
- Claridad
- Bien especificado
- Aptitud para principiantes
- 76/100