google / google/GoogleSignIn-iOS

Expose more advanced OIDAuthorizationRequest configuration options.

未关闭
#28 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
Objective-C
星标
750
派生
282
平均合并
2 天 15 小时
30 天内合并 PR
9

描述

The current interface allows developers to configure their authorization requests on a very basic level with just `clientId`, `audience`, `hosted domain` and `login_hint`, leaving more advanced parameters outside of their control. However, `OIDAuthorizationRequest` exposes a more complex initializer than [the one currently in use](https://github.com/openid/AppAuth-iOS/blob/master/Source/AppAuthCore/OIDAuthorizationRequest.m#L125):

```
- (instancetype)initWithConfiguration:(OIDServiceConfiguration *)configuration
clientId:(NSString *)clientID
clientSecret:(nullable NSString *)clientSecret
scope:(nullable NSString *)scope
redirectURL:(NSURL *)redirectURL
responseType:(NSString *)responseType
state:(nullable NSString *)state
nonce:(nullable NSString *)nonce
codeVerifier:(nullable NSString *)codeVerifier
codeChallenge:(nullable NSString *)codeChallenge
codeChallengeMethod:(nullable NSString *)codeChallengeMethod
additionalParameters:(nullable NSDictionary *)additionalParameters
```
which (in theory) means, that the limitation is only in `GIDConfiguration`.

Since we're talking about a piece of software made by developers for developers, I believe making it more flexible for non-standard and advanced use cases can only improve it.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。