google / google/GoogleSignIn-iOS

Expose more advanced OIDAuthorizationRequest configuration options.

Abierto
#28 0 comentarios 1 reacción 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
Objective-C
Estrellas
750
Forks
282
Merge medio
2 d 15 h
PR fusionados (30 d)
9

Descripción

The current interface allows developers to configure their authorization requests on a very basic level with just `clientId`, `audience`, `hosted domain` and `login_hint`, leaving more advanced parameters outside of their control. However, `OIDAuthorizationRequest` exposes a more complex initializer than [the one currently in use](https://github.com/openid/AppAuth-iOS/blob/master/Source/AppAuthCore/OIDAuthorizationRequest.m#L125):

```
- (instancetype)initWithConfiguration:(OIDServiceConfiguration *)configuration
clientId:(NSString *)clientID
clientSecret:(nullable NSString *)clientSecret
scope:(nullable NSString *)scope
redirectURL:(NSURL *)redirectURL
responseType:(NSString *)responseType
state:(nullable NSString *)state
nonce:(nullable NSString *)nonce
codeVerifier:(nullable NSString *)codeVerifier
codeChallenge:(nullable NSString *)codeChallenge
codeChallengeMethod:(nullable NSString *)codeChallengeMethod
additionalParameters:(nullable NSDictionary *)additionalParameters
```
which (in theory) means, that the limitation is only in `GIDConfiguration`.

Since we're talking about a piece of software made by developers for developers, I believe making it more flexible for non-standard and advanced use cases can only improve it.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.