go-python / go-python/gpython

py.RunFile / RunCode doesn't handle a nil module pointer

未關閉
#249 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Go
星號
1k
分支
105
PR 合併指標
30 天內沒有已合併 PR

描述

Hey, there. It's really cool to be able to run Python in Go! I'd like to congratulate you on this project, it might be exactly what I've been looking for when it comes to an easily embeddable scripting language.

I just noticed that `py.RunFile()` and `py.RunCode()` don't handle a `nil` `py.Module` pointer when deciding to create a new module. I feel like that would lessen the friction on using it, since if you run multiple files and want them to be in a single module you currently have to call two different `RunFile() / RunCode()` calls that are essentially the same (just with `nil` as the `inModule` argument the first time).

Basically, currently I'm doing this:

```go
var mod *py.Module

...

// In a for loop for mutliple .py files

if mod == nil {
mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, nil) // Returns a new module
} else {
mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, mod) // Adds onto the existing one
}
```

and it would be easier to just do this:

```go
var mod *py.Module

...

mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, mod) // Returns a new module on first run because 'mod' is nil, adds onto the existing module afterwards
```

I believe to implement this I would just need to modify `RunCode()` to check for `nil` in the `case *Module` part of the inModule type check. Does this sound OK?

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。