github / github/vscode-github-actions

Setting upstream pushurl to a bad value to prevent pushing prevents branch from being used to find Actions info

Ouverte
#298 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
TypeScript
Étoiles
660
Forks
213
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

**Describe the bug**

If `pushurl` has been set to prevent a remote from being pushable (which I tend to do in order to ensure I never ever push upstream, https://stackoverflow.com/a/10260389), then the extension is unable to find any info about the repo, workflows, secrets, etc.

**To Reproduce**
Steps to reproduce the behavior:
1. Check out a fork.
1. Add an upstream.
1. Set `upstream` to be unpushable using (`git remote set-url --push upstream no_push`)
1. Set `"github-actions.remote-name": "upstream"` in `settings.json`.

**Expected behavior**

The repo works as normal. After all, all of the other settings point to the right places:

```ini
[remote "upstream"]
url = git@github.com:microsoft/TypeScript.git
fetch = +refs/heads/*:refs/remotes/upstream/*
gh-resolved = base
pushurl = no_push
```

**Screenshots**

With pushurl set:

![image](https://github.com/github/vscode-github-actions/assets/5341706/9f8522a6-c9c8-4b08-9543-ff74b0c2a7c4)

![image](https://github.com/github/vscode-github-actions/assets/5341706/26b41309-3104-40c2-bd8c-4e314c799701)

With it unset:

![image](https://github.com/github/vscode-github-actions/assets/5341706/b78588fe-a5de-4888-9f51-900d90ae786a)

![image](https://github.com/github/vscode-github-actions/assets/5341706/1e8d873e-dbbd-4b39-bc8d-c31248e3d168)

**Extension Version**
`v0.26.2`

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start by tracing how the github-actions.remote-name setting resolves the upstream remote and how its Git configuration is read. Reproduce the issue with a pushurl of no_push, then verify that repository, workflow, and secrets information still loads from the remote's url and fetch configuration rather than being rejected because of pushurl.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
git, typescript, vscode
Domaine
ci-cd, devtools
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
45/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.