github / github/vscode-github-actions

Setting upstream pushurl to a bad value to prevent pushing prevents branch from being used to find Actions info

Open
#298 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
660
Forks
213
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**

If `pushurl` has been set to prevent a remote from being pushable (which I tend to do in order to ensure I never ever push upstream, https://stackoverflow.com/a/10260389), then the extension is unable to find any info about the repo, workflows, secrets, etc.

**To Reproduce**
Steps to reproduce the behavior:
1. Check out a fork.
1. Add an upstream.
1. Set `upstream` to be unpushable using (`git remote set-url --push upstream no_push`)
1. Set `"github-actions.remote-name": "upstream"` in `settings.json`.

**Expected behavior**

The repo works as normal. After all, all of the other settings point to the right places:

```ini
[remote "upstream"]
url = git@github.com:microsoft/TypeScript.git
fetch = +refs/heads/*:refs/remotes/upstream/*
gh-resolved = base
pushurl = no_push
```

**Screenshots**

With pushurl set:

![image](https://github.com/github/vscode-github-actions/assets/5341706/9f8522a6-c9c8-4b08-9543-ff74b0c2a7c4)

![image](https://github.com/github/vscode-github-actions/assets/5341706/26b41309-3104-40c2-bd8c-4e314c799701)

With it unset:

![image](https://github.com/github/vscode-github-actions/assets/5341706/b78588fe-a5de-4888-9f51-900d90ae786a)

![image](https://github.com/github/vscode-github-actions/assets/5341706/1e8d873e-dbbd-4b39-bc8d-c31248e3d168)

**Extension Version**
`v0.26.2`

Contributor guide

Open the contributing guide

Research direction

Start by tracing how the github-actions.remote-name setting resolves the upstream remote and how its Git configuration is read. Reproduce the issue with a pushurl of no_push, then verify that repository, workflow, and secrets information still loads from the remote's url and fetch configuration rather than being rejected because of pushurl.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, typescript, vscode
Domain
ci-cd, devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.