github / github/vscode-github-actions

Consider removing `workspaceContains` activation event

未關閉
#246 0 則留言 2 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement
主要語言
TypeScript
星號
660
分支
213
PR 合併指標
30 天內沒有已合併 PR

描述

**Is your feature request related to a problem? Please describe.**

This extension will eagerly activate if I have any workflow files in my repo... even if I don't intend to do any work on GitHub Actions in my repo.

This is because this extension has the following activation event:
https://github.com/github/vscode-github-actions/blob/main/package.json#L28

**Describe the solution you'd like**

Remove this activation event. Your extension will already activate when one of your views open or when you open a workflow file thanks to your [registering of a language](https://github.com/github/vscode-github-actions/blob/main/package.json#L40-L41). This should be sufficient. If it's not, I'm curious to know why.

**Additional context**

Activating eagerly affects other extensions running in the extension host and the ideal situation is that only extensions that are absolutely needed are activated. This keeps VS Code & the extension host lean and fast.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。