github / github/vscode-github-actions

Consider removing `workspaceContains` activation event

未关闭
#246 0 条评论 2 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
TypeScript
星标
660
派生
213
PR 合并指标
30 天内没有已合并 PR

描述

**Is your feature request related to a problem? Please describe.**

This extension will eagerly activate if I have any workflow files in my repo... even if I don't intend to do any work on GitHub Actions in my repo.

This is because this extension has the following activation event:
https://github.com/github/vscode-github-actions/blob/main/package.json#L28

**Describe the solution you'd like**

Remove this activation event. Your extension will already activate when one of your views open or when you open a workflow file thanks to your [registering of a language](https://github.com/github/vscode-github-actions/blob/main/package.json#L40-L41). This should be sufficient. If it's not, I'm curious to know why.

**Additional context**

Activating eagerly affects other extensions running in the extension host and the ideal situation is that only extensions that are absolutely needed are activated. This keeps VS Code & the extension host lean and fast.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。