github / github/vscode-github-actions

Links to specific step logs and duplicate step names

未關閉
#181 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug
主要語言
TypeScript
星號
660
分支
213
PR 合併指標
30 天內沒有已合併 PR

描述

**Describe the bug**
Links to specific step logs implemented in #170 finds step number by step name, but step name may duplicate. Looks like the step number should be retrieved from UI (globe icon of step with which index is clicked?).
https://github.com/github/vscode-github-actions/blob/bed6eac0cb7c76c1487f50402111e30d67c1354b/src/commands/openWorkflowStepLogs.ts#L13

**To Reproduce**
Steps to reproduce the behavior:
1. Clone https://github.com/muzimuzhi/hello-github-actions and open it with vscode
2. Find the 5th run of workflow "Test GitHub Actions itself"
3. Expand steps of its only job "Hello GitHub Actions", click the globe icon next to the second step named "Run dummy commands", also the 4th step
4. https://github.com/muzimuzhi/hello-github-actions/actions/runs/4902036880/jobs/8753647810#step:3:1 opened

![image](https://github.com/github/vscode-github-actions/assets/6376638/e83b3802-0e2f-48d5-8494-ba17dc5174be)

**Expected behavior**
https://github.com/muzimuzhi/hello-github-actions/actions/runs/4902036880/jobs/8753647810#step:4:1 opened. Note it should be `#step:4:1`, not `#step:3:1`.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Extension Version**
`v0.25.7`

貢獻指南

開啟貢獻指南

研究方向

從連結位置的 src/commands/openWorkflowStepLogs.ts 開始,使用 hello-github-actions 儲存庫和第五次 workflow 執行來重現重複名稱的情況。追蹤被點擊的 step 如何被識別,然後確認點擊第二個「Run dummy commands」連結時開啟的是 #step:4:1,而不是 #step:3:1。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
github, typescript
領域
devtools
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
停滯
描述清晰度
描述清楚
新手友好度
48/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。