github / github/vscode-github-actions

Links to specific step logs and duplicate step names

Aberta
#181 2 comentários 0 reações 0 responsáveis Ver no GitHub
bug
Linguagem predominante
TypeScript
Estrelas
660
Forks
213
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

**Describe the bug**
Links to specific step logs implemented in #170 finds step number by step name, but step name may duplicate. Looks like the step number should be retrieved from UI (globe icon of step with which index is clicked?).
https://github.com/github/vscode-github-actions/blob/bed6eac0cb7c76c1487f50402111e30d67c1354b/src/commands/openWorkflowStepLogs.ts#L13

**To Reproduce**
Steps to reproduce the behavior:
1. Clone https://github.com/muzimuzhi/hello-github-actions and open it with vscode
2. Find the 5th run of workflow "Test GitHub Actions itself"
3. Expand steps of its only job "Hello GitHub Actions", click the globe icon next to the second step named "Run dummy commands", also the 4th step
4. https://github.com/muzimuzhi/hello-github-actions/actions/runs/4902036880/jobs/8753647810#step:3:1 opened

![image](https://github.com/github/vscode-github-actions/assets/6376638/e83b3802-0e2f-48d5-8494-ba17dc5174be)

**Expected behavior**
https://github.com/muzimuzhi/hello-github-actions/actions/runs/4902036880/jobs/8753647810#step:4:1 opened. Note it should be `#step:4:1`, not `#step:3:1`.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Extension Version**
`v0.25.7`

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

Start with src/commands/openWorkflowStepLogs.ts at the linked location and reproduce the duplicate-name case using the hello-github-actions repository and the fifth workflow run. Trace how the clicked step is identified, then verify that clicking the second “Run dummy commands” link opens #step:4:1 rather than #step:3:1.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
github, typescript
Domínio
devtools
Tipo de issue
Bug
Dificuldade
3/5
Tempo estimado
1-2 dias
Status de atividade
Estagnada
Clareza
Claramente especificada
Facilidade para iniciantes
48/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.