github / github/vscode-github-actions

Links to specific step logs and duplicate step names

Open
#181 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
660
Forks
213
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Links to specific step logs implemented in #170 finds step number by step name, but step name may duplicate. Looks like the step number should be retrieved from UI (globe icon of step with which index is clicked?).
https://github.com/github/vscode-github-actions/blob/bed6eac0cb7c76c1487f50402111e30d67c1354b/src/commands/openWorkflowStepLogs.ts#L13

**To Reproduce**
Steps to reproduce the behavior:
1. Clone https://github.com/muzimuzhi/hello-github-actions and open it with vscode
2. Find the 5th run of workflow "Test GitHub Actions itself"
3. Expand steps of its only job "Hello GitHub Actions", click the globe icon next to the second step named "Run dummy commands", also the 4th step
4. https://github.com/muzimuzhi/hello-github-actions/actions/runs/4902036880/jobs/8753647810#step:3:1 opened

![image](https://github.com/github/vscode-github-actions/assets/6376638/e83b3802-0e2f-48d5-8494-ba17dc5174be)

**Expected behavior**
https://github.com/muzimuzhi/hello-github-actions/actions/runs/4902036880/jobs/8753647810#step:4:1 opened. Note it should be `#step:4:1`, not `#step:3:1`.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Extension Version**
`v0.25.7`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.