github / github/prettier-config

Please define actions workflow permissions

オープン
#35 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Dockerfile
スター
37
フォーク
15
PR マージ指標
30日以内にマージされた PR はありません

説明

## Workflow permissions improvement

There are **2 workflow files** that are currently lacking explicit permissions

### Affected Workflow Files

The following workflow files need permissions to be explicitly defined:

- [`.github/workflows/publish.yml`](https://github.com/github/prettier-config/blob/main/.github/workflows/publish.yml)
- [`.github/workflows/test.yml`](https://github.com/github/prettier-config/blob/main/.github/workflows/test.yml)

### Request

Ensure permissions are explicitly defined. Below are Copilot prompts/instructions if you would like Copilot's assistance with addressing this.

## GitHub Copilot Assignment Prompts and Context

**Task**: Add explicit permissions to GitHub Actions workflow files that are currently missing them.

**Scope**: Update the workflow files listed above to include appropriate `permissions:` blocks.

**Analysis Methodology**:
1. **Gather Current State**: Check if the workflow has any existing permissions defined
2. **Inventory Workflow Actions**:
- Actions performed directly by the workflow
- API calls made by the workflow
- External actions included via `uses:` statements
3. **Determine Required Permissions**: Map each action to its minimum required permissions
4. **Synthesize Minimal Permissions**: Create permissions block with only necessary permissions

**Requirements**:
1. Add a `permissions:` block to each workflow file that doesn't have one
2. Start with `contents: read` as the minimum permission
3. Add additional permissions only if the workflow actually needs them based on the actions it performs
4. Place the `permissions:` block at the job level or workflow level as appropriate
5. Ensure the syntax is correct and follows YAML formatting
6. Maintain existing content formatting, including indentation and comments

**Files to modify**: See the list of affected workflow files above.

**Acceptance criteria**:
- [ ] All listed workflow files have explicit permissions defined
- [ ] Permissions follow the principle of least privilege
- [ ] YAML syntax is valid
- [ ] Workflows still function correctly after changes

## Copilot Instructions:

Please create a pull request that adds appropriate `permissions:` blocks to each of the workflow files listed above. Analyze each workflow to determine the minimum permissions required based on the actions it performs, and add only those necessary permissions.

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

.github/workflows/publish.yml と .github/workflows/test.yml を読み始め、それらのジョブと uses エントリを一覧化して、必要な最小限の権限を特定します。最小権限の原則に従った明示的な権限を追加し、その後 YAML を検証して、両方のワークフローが引き続き機能することを確認します。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
github-actions
領域
ci-cd, security
issue の種類
リファクタリング
難易度
3/5
見積もり時間
1〜2日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
55/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。