github / github/hotkey

Add support for chords to mapper tool

Open
#89 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.3k
Forks
99
Avg merge
14h 22m
Merged PRs (30d)
6

Description

It would be great if we could also display chords in the mapper tool, similarly to VSCode.

I dug into this a bit and it's more complicated than I expected. If you just have a timer and track keydown events, you get chords like Meta Meta+b because the keydown for Meta is different from the keydown for b. It looks like this is solved in the main code with the 'radix trie' logic, but this seems pretty closely tied to the hotkeys that are configured on the element, and we can't configure _all_ possible hotkeys onto the mapper tool.

Contributor guide

Open the contributing guide

Research direction

Start by tracing the mapper tool and the main code's radix trie logic described in the issue, then compare how VSCode displays chords. Determine how modifier and keydown events should be grouped when all possible hotkeys cannot be configured on the mapper; done means the mapper displays chords without duplicate modifier entries.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.